[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: svn commit: rev 1919 - trunk/subversion/clients/cmdline

From: Sander Striker <striker_at_apache.org>
Date: 2002-05-10 15:54:06 CEST

> Justin Erenkrantz <jerenkrantz@apache.org> writes:
>
> > The code for APR_STATUS_IS_SUCCESS isn't
> > really used anywhere because it's a bad way to do things. It's
> > fine, but I'd rather not set a precedent for that. -- justin
>
> Are you saying that the second value tested by the
> APR_STATUS_IS_SUCCESS macro will never occur? That it is always
> correct to test against zero? If so I assume the macros in
> apr_errno.h should be changed.
>
> Subversion currently has a mixture of APR_STATUS_IS_SUCCESS and
> explict tests. I much prefer consistency, would it be OK to change
> all Subversion's APR_STATUS_IS_SUCCESS() uses into explict tests?

Yes. And +1 to doing so.

> Philip

Sander

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri May 10 15:47:49 2002

This is an archived mail posted to the Subversion Dev mailing list.