Re: svn commit: rev 1919 - trunk/subversion/clients/cmdline

On Fri, May 10, 2002 at 03:54:06PM +0200, Sander Striker wrote:
> > Justin Erenkrantz <jerenkrantz@apache.org> writes:
> >
> > > The code for APR_STATUS_IS_SUCCESS isn't
> > > really used anywhere because it's a bad way to do things. It's
> > > fine, but I'd rather not set a precedent for that. -- justin
> >
> > Are you saying that the second value tested by the
> > APR_STATUS_IS_SUCCESS macro will never occur? That it is always
> > correct to test against zero? If so I assume the macros in
> > apr_errno.h should be changed.
> >
> > Subversion currently has a mixture of APR_STATUS_IS_SUCCESS and
> > explict tests. I much prefer consistency, would it be OK to change
> > all Subversion's APR_STATUS_IS_SUCCESS() uses into explict tests?
>
> Yes. And +1 to doing so.

Definitely. And another +1 from me.

APR_SUCCESS is absolutely and always defined to be zero. Explicitly. And
with the sole purpose being able to easily test for an error.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org