Re: [PATCH] external editor, does this work on Windows...

cmpilato@collab.net writes:

> > * subversion/clients/cmdline/util.c (svn_cl__edit_externally): Check
> > VISUAL before EDITOR. Add system() return value check. Check all
> > function return values. Don't always return success.
>
> I get errors on undefined macros WIFEXITED, WIFSIGNALED, WTERMSIG,
> WEXITSTATUS. I don't think those things are portable.

I wondered what VC would make of those. Is there a <sys/wait.h> file?

I suppose we have to just print the raw return value, which
unfortunately makes it harder for a user to determine why the command
failed. Can we at least assume that zero is success?

Looking at APR's Win32 implementation of apr_proc_wait for inspiration
I see that it doesn't even set the exitwhy return value. This could
be a problem, since on Unix subversion should really be checking that
before deciding that an exit status of zero indicates success.

-- 
Philip
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org