[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] external editor, does this work on Windows...

From: <cmpilato_at_collab.net>
Date: 2002-05-09 18:04:57 CEST

Philip Martin <philip@codematters.co.uk> writes:

> Hi
>
> I believe we should not be ignoring errors when running the external
> editor, and that we should report more error information so that the
> user can determine why it failed. This patch works on Linux, can
> someone with a Windows box tell me if it works there.
>
>
> Put $VISUAL in the conventional place before $EDITOR.
>
> Report system errors if the external editor fails.
>
> * subversion/clients/cmdline/util.c (svn_cl__edit_externally): Check
> VISUAL before EDITOR. Add system() return value check. Check all
> function return values. Don't always return success.

I get errors on undefined macros WIFEXITED, WIFSIGNALED, WTERMSIG,
WEXITSTATUS. I don't think those things are portable.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu May 9 18:05:17 2002

This is an archived mail posted to the Subversion Dev mailing list.