[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 1893 - trunk/subversion/libsvn_subr

From: Karl Fogel <kfogel_at_newton.ch.collab.net>
Date: 2002-05-07 16:31:46 CEST

brane@tigris.org writes:
> Log:
> On Win32, a file can't be deleted if its read-only attribute is set.
>
> * subversion/libsvn_subr/io.c (apr_dir_remove_recursively): Clear the
> read-only attribute before removing a file.

Is this the behavior we want for remove_recursively(), though? Just
curious what the circumstance was that led to this change... Was it
trying to remove a .svn subdir and failing?

-K

> Modified: trunk/subversion/libsvn_subr/io.c
> ==============================================================================
> --- trunk/subversion/libsvn_subr/io.c (original)
> +++ trunk/subversion/libsvn_subr/io.c Tue May 7 08:27:24 2002
> @@ -902,6 +902,13 @@
> }
> else if (this_entry.filetype == APR_REG)
> {
> + status = apr_file_attrs_set (fullpath,
> + 0,
> + APR_FILE_ATTR_READONLY,
> + subpool);
> + if (status && status != APR_ENOTIMPL)
> + return status;
> +
> status = apr_file_remove (fullpath, subpool);
> if (! (APR_STATUS_IS_SUCCESS (status))) return status;
> }
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: svn-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: svn-help@subversion.tigris.org

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue May 7 16:32:31 2002

This is an archived mail posted to the Subversion Dev mailing list.