Re: Reminder: $EDITOR with spaces?

Alan Shutko <ats@acm.org> writes:

> Philip Martin <philip@codematters.co.uk> writes:
>
> > Perhaps we need an APR wrapper for system()?
>
> Sure, if the wrapper knows how to quote filenames for all the shells
> out there, so that operating on files with spaces, returns, colons,
> etc works on all the systems and all the shells out there.

What? The wrapper just passes the raw string to system(). It just
works.

>
> Ok, I'm revising my old proposal. Forget $EDITOR. Don't use it at
> all. It's worthless because people insist on doing stupid stuff like
>
> > EDITOR='LD_LIBRARY_PATH=/some/lib /some/program'
>
> in it.

Works fine with other programs.

> Use a new $SVNEDITOR which is defined as the name of a single
> program. No switches, no environment setting, no tricks. If a user
> wants tricks, they can put it in a script.
>
> Choosing between system() and svn_io_run_cmd() is basically a choice
> between allowing stupid $EDITOR tricks and making sure $EDITOR will
> actually work on all files. Me, I'd take correct behaviour on every
> file over worrying about edge cases whipped up by twisted minds.

A gratuitous incompatibility with other Unix programs is better?

-- 
Philip
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org