[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Reminder: $EDITOR with spaces?

From: Alan Shutko <ats_at_acm.org>
Date: 2002-04-28 23:53:04 CEST

Philip Martin <philip@codematters.co.uk> writes:

> Perhaps we need an APR wrapper for system()?

Sure, if the wrapper knows how to quote filenames for all the shells
out there, so that operating on files with spaces, returns, colons,
etc works on all the systems and all the shells out there.

Ok, I'm revising my old proposal. Forget $EDITOR. Don't use it at
all. It's worthless because people insist on doing stupid stuff like

> EDITOR='LD_LIBRARY_PATH=/some/lib /some/program'

in it. Use a new $SVNEDITOR which is defined as the name of a single
program. No switches, no environment setting, no tricks. If a user
wants tricks, they can put it in a script.

Choosing between system() and svn_io_run_cmd() is basically a choice
between allowing stupid $EDITOR tricks and making sure $EDITOR will
actually work on all files. Me, I'd take correct behaviour on every
file over worrying about edge cases whipped up by twisted minds.

Alan Shutko <ats@acm.org> - In a variety of flavors!
Most public domain software is free, at least at first glance.
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Apr 28 23:54:06 2002

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.