[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Use a subpool in svn_wc_entry()

From: Kevin Pilch-Bisson <kevin_at_pilch-bisson.net>
Date: 2002-03-07 14:55:32 CET

On Wed, Mar 06, 2002 at 11:26:04PM -0500, Ben Collins wrote:
> Hey, look in entry.c for svn_wc__entry_dup(), I think you'll be
> pleasantly surprised :) Here's the same patch, using that function.

Dangit! I need to be more careful about that. Last week it was estimating
unparsed skel sizes, this week it is duping entries...

I should point out that I have a couple (not many) stat's on mem usage with
and without my original patch. All tests performed with rev 1423. The quoted
numbers were obtained by picking the maximum last value for the DRS returned
by the following: while true; do ps v (PID) | grep svn; sleep 1; done.

Status of svn tree:
-------------------
Without patch: 6065
With patch: 5352

Status of (unmodified) kernel tree:
-----------------------------------
Without patch: 29033
With patch: 18784

Now this is just one subcommand, and may be more indicative of a need to use
svn_wc_entries_read, but thought people might like to know.

-- 
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Kevin Pilch-Bisson                    http://www.pilch-bisson.net
     "Historically speaking, the presences of wheels in Unix
     has never precluded their reinvention." - Larry Wall
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

  • application/pgp-signature attachment: stored
Received on Thu Mar 7 14:59:29 2002

This is an archived mail posted to the Subversion Dev mailing list.