Re: [PATCH] Use a subpool in svn_wc_entry()

On Thu, Mar 07, 2002 at 08:55:32AM -0500, Kevin Pilch-Bisson wrote:
> On Wed, Mar 06, 2002 at 11:26:04PM -0500, Ben Collins wrote:
> > Hey, look in entry.c for svn_wc__entry_dup(), I think you'll be
> > pleasantly surprised :) Here's the same patch, using that function.
>
> Dangit! I need to be more careful about that. Last week it was estimating
> unparsed skel sizes, this week it is duping entries...
>
> I should point out that I have a couple (not many) stat's on mem usage with
> and without my original patch. All tests performed with rev 1423. The quoted
> numbers were obtained by picking the maximum last value for the DRS returned
> by the following: while true; do ps v (PID) | grep svn; sleep 1; done.

Yeah, I caught it by total accident. Just dumb luck that I found
svn_wc__entry_dup while looking for something else :)

BTW, you may want to look into the watch command:

watch sh -c "ps v | grep svn | grep -v grep"

I've been using it religously.

> Status of svn tree:
> -------------------
> Without patch: 6065
> With patch: 5352
>
> Status of (unmodified) kernel tree:
> -----------------------------------
> Without patch: 29033
> With patch: 18784
>
> Now this is just one subcommand, and may be more indicative of a need to use
> svn_wc_entries_read, but thought people might like to know.

I actually followed from your patch and looked at some of the users of
svn_wc_entries. We have some places where it is only used to get the URL
of the entry. Others that only use it to get the revision (which
shouldn't have to hold any allocations!), and another just to get the
node kind! None of the used a subpool of anykind. Consider that the
entry being looked at is in a directory (or is a directory) containing
several hundred files, and you've got yourself a lot of wasted space.

Got patches for a few places...still searching for others.

-- 
 .----------=======-=-======-=========-----------=====------------=-=-----.
/       Ben Collins    --    Debian GNU/Linux    --    WatchGuard.com      \
`          bcollins@debian.org   --   Ben.Collins@watchguard.com           '
 `---=========------=======-------------=-=-----=-===-======-------=--=---'
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org