[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: issue #406 patch 2

From: <cmpilato_at_collab.net>
Date: 2001-11-06 19:37:54 CET

Matt Kraai <kraai@alumni.carnegiemellon.edu> writes:

> This is the second in the series of patches to fix issue #406. It
> converts the argument types of svn_fs_{node,txn,revision}_prop. I
> installed a new python, so I was able to verify that it passed the
> entire test suite successfully.

I am thiiiiiiis close ][ to committing this patch. I included with it
a few changes of my own that were relevant.

> * subversion/libsvn_subr/time.c
>
> (svn_time_from_data): New.
> (svn_time_from_string): Accept svn_string_t, call svn_time_from_data.
> (svn_time_from_stringbuf): New.

Matt, just a note for the future. You created svn_time_from_data() as
a static helper function. We generally try to use function names with
prefixes of "svn_" for only public API functions, and "svn_(lib)__"
for functions shared amongst source files within a module, but not
publicized outside the module. You probably should have named your
helper function something like just time_from_data().

At any rate, it doesn't matter. When I realized that we now had a
helper that accepted a null-terminated string (nts) and two wrappers
that took svn_string_t's and svn_stringbuf_t's and then simply dumped
the ->data fields of each of those types into your helper, it was
apparent that your helper function should have just become the public
API.

So, now there is no more svn_time_from_string OR svn_time_from_stringbuf,
only svn_time_from_nts (which was your svn_time_from_data). :-)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:48 2006

This is an archived mail posted to the Subversion Dev mailing list.