[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: issue #406 patch 2

From: Karl Fogel <kfogel_at_newton.ch.collab.net>
Date: 2001-11-01 17:41:18 CET

cmpilato@collab.net writes:
> Just a quick concern here, before I review this in great depth. I may
> be completely off my rocker here (it's been a long week...oh God, it's
> only Tuesday...kill me now), but would I be incorrect in recalling
> that we wanted counted strings for property names and values so we
> could have binary contents for both?
>
> I'm certain that we want binary property values. It's the property
> names I'm not sure of. Dev-list, are you out there? Please let me
> know (gently, I'm very fragile :-) whazzup with our intended property
> support.

I believe we all agreed a long time ago that prop names didn't have to
be binary (that is, they don't have 0 bytes -- decided specifically so
`char *' would be a safe holder for them).

If we didn't before, I hope we can agree so now. :-)

-K

> Thanks. Other than that concern, an initial application of the patch
> seems to go over relatively smoothly--got one conflict due, I think,
> to Karl's reorg of the `svn log' codepath, and one missed instance in
> fetch.c of a call to svn_xml_escape_string() that should now be
> svn_xml_escape_stringbuf(), that's it. Didn't run `make check' yet.
>
> Hm. Sleepy. G'night.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:47 2006

This is an archived mail posted to the Subversion Dev mailing list.