[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: issue #406 patch 2

From: Karl Fogel <kfogel_at_newton.ch.collab.net>
Date: 2001-11-06 20:56:48 CET

cmpilato@collab.net writes:
> Matt, just a note for the future. You created svn_time_from_data() as
> a static helper function. We generally try to use function names with
> prefixes of "svn_" for only public API functions, and "svn_(lib)__"
> for functions shared amongst source files within a module, but not
> publicized outside the module.

The relevant bit from HACKING is

   * Signify internal variables by two underscores after the prefix.
     That is, when a symbol must (for technical reasons) reside in the
     global namespace despite not being part of a published interface,
     then use two underscores following the module prefix. For
     example:

        svn_fs_get_rev_prop () /* Part of published API. */
        svn_fs__parse_props () /* For internal use only. */

So note that the important difference is the presence of the extra
underscore, not the presence of the <lib> name. Of course, file-local
static functions don't get any special prefix at all.

-K

> At any rate, it doesn't matter. When I realized that we now had a
> helper that accepted a null-terminated string (nts) and two wrappers
> that took svn_string_t's and svn_stringbuf_t's and then simply dumped
> the ->data fields of each of those types into your helper, it was
> apparent that your helper function should have just become the public
> API.
>
> So, now there is no more svn_time_from_string OR svn_time_from_stringbuf,
> only svn_time_from_nts (which was your svn_time_from_data). :-)
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:48 2006

This is an archived mail posted to the Subversion Dev mailing list.