[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 333 - trunk/subversion/libsvn_ra_local trunk/subversion/clients/cmdline

From: Greg Stein <gstein_at_lyra.org>
Date: 2001-10-28 01:32:19 CEST

On Sat, Oct 27, 2001 at 01:40:35AM -0500, kfogel@tigris.org wrote:
>...
> + /* The result of svn_time_to_string() looks something like this:
> + *
> + * "Sat 2 Mar 2002 20:41:01.695108 (day 061, dst 0, gmt_off -21600)"
> + *
> + * You might think the part before the dot would be constant length,
> + * but apparently it's not; so we grab it the hard way.

Why don't we make it fixed length? It isn't like we *need* it to be variable
length.

Further, why is the day, dst, and gmt_off in there? We don't need any of
those for anything do we?

We can easily simplify things by pushing back on other aspects of our code.

>...
> + printf ("rev %lu: %s %s, %d bytes\n", rev, author, dbuf, strlen (msg));

Users will be confused by that "103 bytes" in there. Bytes for what? The
diff? It will take a bit before they realize "oh! the length of the log
message."

Users don't need that value. I don't think it is right to put it in there.

And if you want to say "but we want a parsable output", then use XML. Or a
flag or something. But don't burden *users* with stuff only intended for a
program. Not to mention the program can figure it out for itself anyways
just by scanning for the "-----" separator.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:46 2006

This is an archived mail posted to the Subversion Dev mailing list.