[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 326 - trunk/subversion/libsvn_wc trunk/subversion/libsvn_ra_local trunk/subversion/libsvn_client

From: Greg Stein <gstein_at_lyra.org>
Date: 2001-10-28 01:04:21 CEST

On Fri, Oct 26, 2001 at 05:58:41PM -0500, sussman@tigris.org wrote:
>...
> +++ NEW/trunk/subversion/libsvn_ra_local/commit_editor.c Fri Oct 26 17:58:41 2001
>...
> @@ -226,18 +229,34 @@
>
> if (copyfrom_path)
> {
> - /* If the driver supplied ancestry args, the filesystem can make a
> - "cheap copy" under the hood... how convenient! */
> + svn_stringbuf_t *repos_path;
> + svn_stringbuf_t *fs_path;
> svn_fs_root_t *copyfrom_root;
>
> + /* This add has history. Let's split the copyfrom_url. */
> + SVN_ERR (svn_ra_local__split_URL (&repos_path, &fs_path,
> + copyfrom_path, new_dirb->subpool));
> +
> + /* For now, require that the url come from the same repository
> + that this commit is operating on. */
> + if (! svn_stringbuf_compare (eb->session->repos_path, repos_path))
> + return
> + svn_error_createf
> + (SVN_ERR_FS_GENERAL, 0, NULL, eb->pool,
> + "fs editor: add_file`%s': copyfrom_url is from different repo",

This is in add_directory()

>...
> +++ NEW/trunk/subversion/libsvn_ra_local/ra_plugin.c Fri Oct 26 17:58:41 2001
> @@ -219,6 +219,7 @@
>
> /* Get the repos commit-editor */
> SVN_ERR (svn_ra_local__get_editor (&commit_editor, &commit_editor_baton,
> + sess_baton,
> sess_baton->fs,
> sess_baton->fs_path,
> sess_baton->username,

Can't you simplify the calling params now? Since you're passing sess_baton,
all those other things can just be yanked from there.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:46 2006

This is an archived mail posted to the Subversion Dev mailing list.