[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] svn_path_canonicalize

From: Kevin Pilch-Bisson <kevin_at_pilch-bisson.net>
Date: 2001-09-19 14:57:54 CEST

On Wed, Sep 19, 2001 at 07:53:28AM -0400, Garrett Rooney wrote:
> i guess i just saw 'url being passed to a function that claims to take
> a path' and thought 'ewww', but if people would prefer i could rework
> the patch to do everything from svn_path_canonicalize.

I'd wait for others comments, before working on a new patch.
>
> at the moment, i the patches replace the calls in the path library
> with code that explicitly removes trailing dirseps (which is all
> svn_path_canonicalize was doing anyway). i figured if one wants the
> path canonicalized one should explicitly call it, rather than having
> it go on behind your back, especially since we were passing both
> path's and url's to those functions.

Well I seem to remember something in the docstring in svn_path.h about all path
routines returning canonicalized paths, but it has been a while.

> having svn_path_canonicalize
> check the style would handle that though, so i guess it's not a
> problem.
>
> anway, just say the word. if people would like to be able to pass
> url's to svn_path_canonicalize, it can easily be that way.

Like I said, lets wait and see what others have to say.
>
> --
> garrett rooney Unix was not designed to stop you from
> rooneg@electricjellyfish.net doing stupid things, because that would
> http://electricjellyfish.net/ stop you from doing clever things.
>

-- 
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Kevin Pilch-Bisson                    http://www.pilch-bisson.net
     "Historically speaking, the presences of wheels in Unix
     has never precluded their reinvention." - Larry Wall
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

  • application/pgp-signature attachment: stored
Received on Sat Oct 21 14:36:41 2006

This is an archived mail posted to the Subversion Dev mailing list.