Re: [PATCH] svn_path_canonicalize

On Wed, Sep 19, 2001 at 06:24:37AM -0400, Kevin Pilch-Bisson wrote:
> I haven't really looked at this patch, but I have a question already. There
> are several places where svn_path_canonicalize are called from within other
> parts of the path library. I was thinking we could make url_canonicalize
> private to path.c and make svn_path_canonicalize look like:
>
> if (style == svn_path_url_style)
> url_canonicalize(path);
> else
> {
> /* Do our non-url canonicalization. */
> }
>
> This also means nothing outside of path.c has to change.

i guess i just saw 'url being passed to a function that claims to take
a path' and thought 'ewww', but if people would prefer i could rework
the patch to do everything from svn_path_canonicalize.

at the moment, i the patches replace the calls in the path library
with code that explicitly removes trailing dirseps (which is all
svn_path_canonicalize was doing anyway). i figured if one wants the
path canonicalized one should explicitly call it, rather than having
it go on behind your back, especially since we were passing both
path's and url's to those functions. having svn_path_canonicalize
check the style would handle that though, so i guess it's not a
problem.

anway, just say the word. if people would like to be able to pass
url's to svn_path_canonicalize, it can easily be that way.

-- 
garrett rooney                     Unix was not designed to stop you from 
rooneg@electricjellyfish.net       doing stupid things, because that would  
http://electricjellyfish.net/      stop you from doing clever things.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org