Re: [PATCH] svn_path_canonicalize

Kevin Pilch-Bisson wrote:

>I haven't really looked at this patch, but I have a question already. There
>are several places where svn_path_canonicalize are called from within other
>parts of the path library. I was thinking we could make url_canonicalize
>private to path.c and make svn_path_canonicalize look like:
>
>if (style == svn_path_url_style)
> url_canonicalize(path);
>else
> {
> /* Do our non-url canonicalization. */
> }
>
>This also means nothing outside of path.c has to change.
>
>Other's thoughts?
>
+1

Conceptionally, the svn_path_*_style constants select a style, not a
path separator. At this level, an URL is definitely a "path style"
(although note that we implicitly support only file:// and http(s)://
schemas in this function). Therefore the decision about whether to merge
consecutive directory separators, whether ".." means "one level up", etc
... is a property of the style, not the function name.

-- 
Brane �ibej   <brane_at_xbc.nu>            http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org