[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: make check

From: Greg Stein <gstein_at_lyra.org>
Date: 2001-06-01 21:07:14 CEST

On Fri, Jun 01, 2001 at 01:48:16PM -0400, Kevin Pilch-Bisson wrote:
> On Fri, Jun 01, 2001 at 11:59:34AM -0500, Ben Collins-Sussman wrote:
> > 1. All test programs (be they binaries or scripts) live somewhere in
> > subversion/tests/.
> >
> > 2. Each test program should verify its own location in the
> > tree. (This can be done by looking for "../../../README" or
> > something.)
>
> The reason for the argument is in vpath builds. Say I have a

Yup. This is exactly why I provided it to (all) the test programs/scripts.
If they need some kind of control/source input, then they'll be able to find
it.

In fact, I believe three of the test scripts use it:
client/tests/svn_test*.sh and tests/libsvn_wc/checkout-test.sh

The libsvn_test framework ignores the thing, but it could also capture it
for use by the test programs. This would probably be best because I bet the
test programs can't find tests/xml/, tests/greek-repos/, etc.

>...
> 1) Have test programs that rely on something from srcdir take an
> argument of where that thing is.
>...
> I chose solution 1 for the old system, since I found it easier to work
> with for the automake case.

It is still the (IMO) best solution, with or without automake.

> Now that we have a home-grown make
> system, perhaps someone wants to add something such that solution 2 is
> used.

Copying the input (option 2) is probably unworkable. Just *what* should be
copied? And some of that data could get quite large (greek-repos is 788k).
It is easier to simply use a srcdir argument.

> Personally, I would prefer another attribute for the tests,
> which would allow us to specify arbitrary arguments to each test
> individually.

While we could add this, I'd simply recommend a .sh file that supplies the
arguments to whatever you're thinking of. The make scripts can't supply
*variable* arguments; if they're fixed, then they may as well go into a test
script rather than the build.conf file.

I think it would be *much* more transparent to developers to put the (fixed)
arguments into a .sh script.

>...
> Also note that vpath builds are currently broken by the new build
> system, but at some point I plan to hack on it until they are working
> again.

I don't know how these work; I've never used them. But I also knew that I
broke them :-( ... Please feel free to fix it, or provide a bit of education
for me so that I can dig in. Looks like we need a couple things? Setting
VPATH and creating directories?

thx,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:31 2006

This is an archived mail posted to the Subversion Dev mailing list.