Re: make check

On Fri, Jun 01, 2001 at 11:59:34AM -0500, Ben Collins-Sussman wrote:
> 1. All test programs (be they binaries or scripts) live somewhere in
> subversion/tests/.
>
> 2. Each test program should verify its own location in the
> tree. (This can be done by looking for "../../../README" or
> something.)
>
>

The reason for the argument is in vpath builds. Say I have a
subversion source tree at /home/kevin/svn-src, and I build it from
/home/kevin/svn-bld. Then the scripts need to know where the src dir
is, in order to find the xml files. Basically, any script which
relies on something that is not built as part of the build process
needs to know where that thing is. (Note that having the make system
cd to the srcdir is not acceptable either, since the srcdir should be
able to be a read-only filesystem. There are two solutions to this
problem:

1) Have test programs that rely on something from srcdir take an
argument of where that thing is.

2) Have the make (or make check) rules copy those items into the
builddir before running the test.

I chose solution 1 for the old system, since I found it easier to work
with for the automake case. Now that we have a home-grown make
system, perhaps someone wants to add something such that solution 2 is
used. Personally, I would prefer another attribute for the tests,
which would allow us to specify arbitrary arguments to each test
individually.

Any other ideas?

Also note that vpath builds are currently broken by the new build
system, but at some point I plan to hack on it until they are working
again.

-- 
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Kevin Pilch-Bisson                    http://www.pilch-bisson.net
     "Historically speaking, the presences of wheels in Unix
     has never precluded their reinvention." - Larry Wall
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~