Re: make check

On Fri, Jun 01, 2001 at 12:07:14PM -0700, Greg Stein wrote:
> ...
> On Fri, Jun 01, 2001 at 01:48:16PM -0400, Kevin Pilch-Bisson wrote:
> >...
> > 1) Have test programs that rely on something from srcdir take an
> > argument of where that thing is.
> >...
> > I chose solution 1 for the old system, since I found it easier to work
> > with for the automake case.
>
> It is still the (IMO) best solution, with or without automake.

Now that you mention it, I guess you are right.

>
> > Now that we have a home-grown make
> > system, perhaps someone wants to add something such that solution 2 is
> > used.
>
> Copying the input (option 2) is probably unworkable. Just *what* should be
> copied? And some of that data could get quite large (greek-repos is 788k).
> It is easier to simply use a srcdir argument.

I hate being able to think faster than I type:), I meant to say
exactly this, but it slipped my mindd before I finished typing other
stuff.

>
> > Personally, I would prefer another attribute for the tests,
> > which would allow us to specify arbitrary arguments to each test
> > individually.
>
> While we could add this, I'd simply recommend a .sh file that supplies the
> arguments to whatever you're thinking of. The make scripts can't supply
> *variable* arguments; if they're fixed, then they may as well go into a test
> script rather than the build.conf file.
>
> I think it would be *much* more transparent to developers to put the (fixed)
> arguments into a .sh script.

Good point, I'm with you on this.

>
> >...
> > Also note that vpath builds are currently broken by the new build
> > system, but at some point I plan to hack on it until they are working
> > again.
>
> I don't know how these work; I've never used them. But I also knew that I
> broke them :-( ... Please feel free to fix it, or provide a bit of education
> for me so that I can dig in. Looks like we need a couple things? Setting
> VPATH and creating directories?
>

Well, with a single makefile, I don't think it will be possible to set
VPATH, since it can AFAIK only be set to one dir. Instead I think you
will have to do something like this for you compiling rules.

$(buildir)/path/in/svn/tree/%.o: $(srcdir)/path/in/svn/tree/%.c
        gcc -c -o $@ $<

(Now this can cause problems, because some compilers won't allow you
to specify both -c and -o (although autoconf should check this)). The
other problem is that you will probably now need a build rule for each
of the directories. Hmm... Needs more thought.

-- 
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Kevin Pilch-Bisson                    http://www.pilch-bisson.net
     "Historically speaking, the presences of wheels in Unix
     has never precluded their reinvention." - Larry Wall
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~