[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: CVS update: MODIFIED: libsvn_wc ...

From: Greg Stein <gstein_at_lyra.org>
Date: 2001-05-12 21:59:33 CEST

On Fri, May 11, 2001 at 04:18:02PM -0000, cmpilato@tigris.org wrote:
>...
> (write_entry, svn_wc__entries_write): Optimizations per the watchful
> eye of GregS.

hehe...

>...
> --- entries.c 2001/05/11 05:26:09 1.98
> +++ entries.c 2001/05/11 16:18:02 1.99
>...
> @@ -719,24 +718,20 @@
> apr_size_t keylen;
> void *val;
> svn_wc_entry_t *this_entry;
> - svn_string_t *name;
>
> /* Get the entry and make sure its attributes are up-to-date. */
> apr_hash_this (hi, &key, &keylen, &val);
> this_entry = val;
>
> - /* Get the entry's name. */
> - name = svn_string_ncreate (key, keylen, pool);
> -
> /* Don't rewrite the "this dir" entry! */
> - if (svn_string_compare (name, this_dir_name))
> + if (! strcmp ((const char *)key, SVN_WC_ENTRY_THIS_DIR ))

Given that key is "void *", this cast shouldn't be needed.

> continue;
>
> /* Normalize this entry */
> normalize_entry (this_entry, pool);
>
> /* Append the entry to BIGSTR */
> - write_entry (&bigstr, this_entry, name, this_dir, pool);
> + write_entry (&bigstr, this_entry, (const char *)key, this_dir, pool);

Same here.

(I'm changing them now; this email just as a note for future dev)

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:30 2006

This is an archived mail posted to the Subversion Dev mailing list.