[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [cmpilato@collab.net] That last checkin...

From: Greg Stein <gstein_at_lyra.org>
Date: 2001-04-17 22:36:35 CEST

On Tue, Apr 17, 2001 at 03:04:11PM -0500, Karl Fogel wrote:
> Mike Pilato sent this to the cvs commit list instead of dev, so here
> it is in Official Stereo Simulcast:
> "That last checkin breaks stuff. I'm currently moving some stuff
> from libsvn_fs to libsvn_repos, and am unfinished."

Note to others: the reason this breaks stuff is that the fs/delta.c file was
moved *intact*. It isn't going to compile properly in its new location.

However, this is actually the ideal situation. Consider the two cases:

1) move the file, get it to compile, check it in
2) move the file, check it in, get it to compile, check it in

In case (2), we get to review the get-it-to-compile changes. In case (1), we
see a big-ass file suddenly appear. There is no way to compare changes
between its new and old locations (without a fuggin' lot of work).

Using scheme (2) subjects us to short-term breakage, but gives us much
better reviewability of changes.

This applies to moving functions, too. Any changes to a function "in
transit" wouldn't be seen in the checkin email at the new location (and
those changes are *much* harder to review since functions are buried within
files). So... ideally, you move the function with no changes (stating so in
the commit message), *then* go in and patch it up. We can then see what was
done to the function, and verify the changes.


Greg Stein, http://www.lyra.org/
Received on Sat Oct 21 14:36:28 2006

This is an archived mail posted to the Subversion Dev mailing list.