Re: CVS update: subversion/subversion/libsvn_subr svn_string.c

On Fri, Oct 13, 2000 at 09:42:17PM -0500, Karl Fogel wrote:
>...
> (The main casting I see going on is when we cast all those (void *)
> batons and userData arguments back to their rightful types at the top
> of parser and editor callback functions. Those casts are fairly
> numerous, and as far as I understand, they are necessary too.)

Euh... not necessary. This is totally legit:

   some_struct_type *foo = some_void_ptr;

There is an implicit cast in there.

What you cannot do, however, is take the address of a void* variable and
pass it as a some_type** argument. In other words:

   BAD: call_some_func(&void_ptr);
   
   GOOD: my_type *foo = void_ptr;
         call_some_func(&foo);

There are implicit casts to/from void ptrs in assignments and func calls.

[ example: fetch.c::fetch_file_reader() ... no cast on the userdata ]

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/