Re: CVS update: subversion/subversion/libsvn_subr svn_string.c

Greg Hudson <ghudson@MIT.EDU> writes:
> Just so that your understanding is correct: they are not necessary for
> any reason in C. (Except on very old compilers which wouldn't
> understand our function declarations anyway.) They will generate a
> warning in C++. We have no particular design goal of making our code
> compile under a C++ compiler, but it might be worthwhile to go to
> minimal effort not to make such a thing unnecessarily difficult.

Thank you. I'll probably take them out, then; I don't think they're
contributing to understanding, the type declarations do that well
enough.

> I don't have a particular opinion on the subject. I think the clutter
> and the explanatory value of such casts are roughly equal, so I'm
> happy to have them or not to have them.

Ahh, neutrality -- always the most dangerous position. :-)
Received on Sat Oct 21 14:36:11 2006