[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: CVS update: subversion/subversion/libsvn_delta/tests Makefile.am

From: Greg Stein <gstein_at_lyra.org>
Date: 2000-09-21 21:20:20 CEST

And those threading switches (such as -pthread) should not be hard-coded.
They should be derived via autoconf. APR already does this, but needs to
export them via APRVARS. Branko made a first pass at doing that. However, it
seemed to treat the threading flags as special, rather than export all
necessary flags.

Cheers,
-g

On Thu, Sep 21, 2000 at 02:55:54PM -0400, Greg Hudson wrote:
> Karl committed:
> > -CFLAGS = -pthread
> > +CFLAGS = @CFLAGS@ -pthread
>
> This is better, but still wrong according to the gnu makefile
> standards; I've included the relevant fragment below. Similarly,
> aclocal.m4 macros are not supposed to stuff required flags into the
> CFLAGS environment variable.
>
> ---
>
> If there are C compiler options that *must* be used for proper
> compilation of certain files, do not include them in `CFLAGS'. Users
> expect to be able to specify `CFLAGS' freely themselves. Instead,
> arrange to pass the necessary options to the C compiler independently
> of `CFLAGS', by writing them explicitly in the compilation commands or
> by defining an implicit rule, like this:
>
> CFLAGS = -g
> ALL_CFLAGS = -I. $(CFLAGS)
> .c.o:
> $(CC) -c $(CPPFLAGS) $(ALL_CFLAGS) $<
>
> Do include the `-g' option in `CFLAGS', because that is not
> *required* for proper compilation. You can consider it a default that
> is only recommended. If the package is set up so that it is compiled
> with GCC by default, then you might as well include `-O' in the default
> value of `CFLAGS' as well.

-- 
Greg Stein, http://www.lyra.org/
Received on Sat Oct 21 14:36:08 2006

This is an archived mail posted to the Subversion Dev mailing list.