Re: CVS update: subversion/subversion/libsvn_delta/tests Makefile.am

Greg Hudson wrote:

>Karl committed:
>> -CFLAGS = -pthread
>> +CFLAGS = @CFLAGS@ -pthread
>
>This is better, but still wrong according to the gnu makefile
>standards; I've included the relevant fragment below. Similarly,
>aclocal.m4 macros are not supposed to stuff required flags into the
>CFLAGS environment variable.

Actially, CFLAGS shouldn't be changed in subdir makefiles; automake will
propagate the value from the top level, I believe. I'll also point out,
as I've done before, that hard-coding the `-pthread' flag is wrong. For
instance, on Solaris 2.6 with gcc, you need

    -pthreads -D_POSIX_PTHREAD_SEMANTICS -D_REENTRANT

The APR configure already sets the correct flags for quite a few
systems. Ideally, Subversion would use APR's values, but I confess I
don't know a clean way to do that (note that APR puts those flags
directoy into CFLAGS, too; perhaps this should be changed?). Another
possibility is to do the tests in the top-level configure. Maybe we
could reuse apr/apr_common.m4.

In any case I'd very much like to see this issue resolved. I'm willing
to do the dirty work to fix it, but I'd like to hear other people's
opinions first.

    Brane
Received on Sat Oct 21 14:36:08 2006