[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

AW: [Patch] fix for compilation error, when compiled with "-pedantic" option

From: Markus Schaber <m.schaber_at_3s-software.com>
Date: Thu, 27 Oct 2011 07:26:47 +0000

Hi,

Von: Prabhu Gnana Sundar [mailto:prabhugs_at_collab.net]
> Not sure if the trailing commas at the end of enumerator lists are typos,
> though fixing quite a few of them in the patch attached. I have also
> attached the log message with this mail.
> Please share your views.

I'm not sure about the subversion coding style guide, but there are several style guides advising to put a comma after the last member of enumeration lists.

The reason: If the enum is extended with further members, it is not needed to modify the line defining the last member to add the comma. This keeps diffs/patches cleaner and more concise.

Best regards

Markus Schaber

-- 
___________________________
We software Automation.
3S-Smart Software Solutions GmbH
Markus Schaber | Developer
Memminger Str. 151 | 87439 Kempten | Germany | Tel. +49-831-54031-0 | Fax +49-831-54031-50
Email: m.schaber@3s-software.com | Web: http://www.3s-software.com 
CoDeSys internet forum: http://forum.3s-software.com
Download CoDeSys sample projects: http://www.3s-software.com/index.shtml?sample_projects
Managing Directors: Dipl.Inf. Dieter Hess, Dipl.Inf. Manfred Werner | Trade register: Kempten HRB 6186 | Tax ID No.: DE 167014915 
Received on 2011-10-27 09:27:31 CEST

This is an archived mail posted to the Subversion Dev mailing list.