[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: AW: [Patch] fix for compilation error, when compiled with "-pedantic" option

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: Thu, 27 Oct 2011 09:21:25 +0100 (BST)

Markus Schaber wrote:
> Von: Prabhu Gnana Sundar [mailto:prabhugs_at_collab.net]
> > Not sure if the trailing commas at the end of enumerator lists are typos,
> > though fixing quite a few of them in the patch attached. I have also
> > attached the log message with this mail.
> > Please share your views.
>
> I'm not sure about the subversion coding style guide, but
> there are several style guides advising to put a comma after
> the last member of enumeration lists.
>
> The reason: If the enum is extended with further members,
> it is not needed to modify the line defining the last member
> to add the comma. This keeps diffs/patches cleaner and more
> concise.

That's useful for lists that get extended regularly, but we hardly ever extend an enumeration list and it's good to stick to standards where it doesn't hurt us to do so, so I would like us to remove the commas.

- Julian
Received on 2011-10-27 10:23:36 CEST

This is an archived mail posted to the Subversion Dev mailing list.