[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [Patch] fix for compilation error, when compiled with "-pedantic" option

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Thu, 27 Oct 2011 10:21:18 +0200

Markus Schaber wrote on Thu, Oct 27, 2011 at 07:26:47 +0000:
> Hi,
>
> Von: Prabhu Gnana Sundar [mailto:prabhugs_at_collab.net]
> > Not sure if the trailing commas at the end of enumerator lists are typos,
> > though fixing quite a few of them in the patch attached. I have also
> > attached the log message with this mail.
> > Please share your views.
>
> I'm not sure about the subversion coding style guide, but there are
> several style guides advising to put a comma after the last member of
> enumeration lists.
>
> The reason: If the enum is extended with further members, it is not
> needed to modify the line defining the last member to add the comma.
> This keeps diffs/patches cleaner and more concise.

It's not a coding style issue, it's a syntax issue. C89 doesn't allow
that trailing comma.
Received on 2011-10-27 10:22:03 CEST

This is an archived mail posted to the Subversion Dev mailing list.