Re: Issue: Top-level --with-expat option does not accept apr-util's "builtin" argument

Hi Stefan,

On Wed, 2012 Jun 20 12:05+0200, Stefan Sperling wrote:
> >
> > +# apr-util accepts "builtin" as an argument to this option
> > +test "_$svn_lib_expat" = "_builtin" && svn_lib_expat="::expat"
>
> Looks like this will make the script error out without an error
> message. That might confuse people. Can you please add an error
> message?

Do you mean, this causes the script to error out in "set -e" mode? If
that's it, the line could be re-written as

    test "_$svn_lib_expat" != "_builtin" || svn_lib_expat="::expat"

This isn't meant to raise an error at all; the aim is to fool the
top-level script into thinking the user didn't specify --with-expat=* in
this one specific case.

--Daniel

-- 
Daniel Richard G. || skunk_at_iSKUNK.ORG
My ASCII-art .sig got a bad case of Times New Roman.