Re: Issue: Top-level --with-expat option does not accept apr-util's "builtin" argument

On Tue, Jun 19, 2012 at 02:10:02PM -0400, Daniel Richard G. wrote:
> Index: configure.ac
> ===================================================================
> --- configure.ac (revision 1351789)
> +++ configure.ac (working copy)
> @@ -373,6 +373,9 @@
> [svn_lib_expat="$withval"],
> [svn_lib_expat="::expat"])
>
> +# apr-util accepts "builtin" as an argument to this option
> +test "_$svn_lib_expat" = "_builtin" && svn_lib_expat="::expat"
> +

Looks like this will make the script error out without an error message.
That might confuse people. Can you please add an error message?

I'd also prefer your test to happen after this message is printed:
> AC_MSG_CHECKING([for Expat])

> if test -n "`echo "$svn_lib_expat" | $EGREP ":.*:"`"; then
> SVN_XML_INCLUDES=""
Received on 2012-06-20 12:06:36 CEST