[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: "svn commit" does not work with SVNParentPath in location and 1.7-client (HTTPv2)

From: Philip Martin <philip.martin_at_wandisco.com>
Date: Thu, 17 Nov 2011 14:37:36 +0000

Stefan Sperling <stsp_at_elego.de> writes:

> Yes, of course it works with SVNParentPath. But I suspect that is
> a result of implementation rather than concious design.

Perhaps, but the line that stops it working looks like an outright bug.
  newconf->root_dir = INHERIT_VALUE(child, parent, root_dir);

The order of parent and child in Subversion's INHERIT_VALUE macro only
has an effect when nesting one Subversion location in another. When not
nested the parent root_dir is NULL and the child value will be used
whatever the order in INHERIT_VALUE. I can't see how it would ever be
correct to inherit the parent root_dir value.

This bug only comes to light because 1.7 uses the root_dir value when
processing POST requests; 1.6 doesn't use POST requests so the wrong
value had no effect.

Received on 2011-11-17 15:38:28 CET

This is an archived mail posted to the Subversion Users mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.