[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Failure using "svn patch" with Git patch that adds files. Wrong path is used.

From: Nico Kadel-Garcia <nkadel_at_gmail.com>
Date: Sun, 6 Nov 2011 08:56:34 -0500

On Sat, Nov 5, 2011 at 1:58 PM, Stefan Sperling <stsp_at_elego.de> wrote:
> On Sat, Nov 05, 2011 at 04:37:03PM +0100, Stefan Sperling wrote:
>>     Currently, "/dev/null" is not special-cased (it is most certainly
>>     special-cased in git), which causes one of the problem where a file
>>     is added with a wrong name.
>>     I think this should be fixed in 'svn patch', so that '/dev/null'
>>     is treated in a special way.
> This problem should be fixed by this commit:
> http://svn.apache.org/viewvc?view=revision&amp;revision=1197998
> I've nominated it for inclusion in Subversion 1.7.2.

Stefan, if I may suggest, special-casing file names is leaving trouble
lying in wait. It would be safer to handle it via special file types.
/dev/null is a "character special" filetype in UNIX and Linux,
Character devices, block devices, and pipes should be ignored or
cause errors when source control tries to manipulate them.

/dev/null is unusual in that it has write and read access to all
users, but I've seen too many cases where Subversion is being used by
root logins to administer system files and has privileges to
manipulate block devices, such as your disk drive. Rather than trying
to guess what names such devices should have, why not block operations
on a more powerful category that Subversion very clearly should not be
Received on 2011-11-06 14:57:07 CET

This is an archived mail posted to the Subversion Users mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.