Re: svnserv + ssh + ldap

Nico Kadel-Garcia wrote:

>> $ export `gnome-keyring-daemon`
>
> Good, but ouch. Let's try adding a bit of rigor, shall we? First,
> before running such a daemon, always check that it actually exists,
> where you expect it to exist. Running random commands that will handle
> passwords which may have been replaced by who knows what somehwere in
> your $PATH is always a bad idea. So let's use this instead:
>
> if [ -x /usr/bin/gnome-keyring-daemon ]; then
> export `gnome-keyring-daemon`
> fi

Shouldn't this be like this?

     if [ -x /usr/bin/gnome-keyring-daemon ]; then
         export `/usr/bin/gnome-keyring-daemon`
     fi

Otherwise there is not really an improvement to before, only a protection against "file
does not exist".

Paul
Received on 2010-08-03 15:30:00 CEST