On Tue, Aug 03, 2010 at 02:36:41PM +0200, Vincent Lefevre wrote:
> On 2010-08-03 12:56:28 +0200, Stefan Sperling wrote:
> > On Tue, Aug 03, 2010 at 10:33:28AM +0000, Florian Weimer wrote:
> > > Kernel-level buffers are taken into account. Application buffers
> > > aren't, the application has to take care of that. But if the
> > > Subversion fails to do that, it cannot recover from file system
> > > crashes, either, which is arguably a bug in Subversion.
> >
> > Subversion carefully flushes file buffers after writing revision files.
>
> What do you mean by "flushes file buffers"? A call to fflush()?
> Or a call to sync() or fsync() too?
>
> Assuming the filesystem is on a remote machine (say, NFS), the
> necessary needs to be done on the client side: the NFS server
> cannot take into account the kernel-level buffers of the client.
Subversion calls apr_file_flush(). What that does on which platform
depends on APR (and could theoretically change over time).
I'm not sure what else you suggest we should do to avoid the (from
my point of view non-existent) bug you were talking about.
Stefan
Received on 2010-08-03 15:13:07 CEST