[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: XFAIL executing make check on SVN 1.6.5

From: Daniel Becroft <djcbecroft_at_gmail.com>
Date: Thu, 29 Oct 2009 13:20:13 +1000

On Wed, Oct 28, 2009 at 7:34 PM, Ryan Schmidt <
subversion-2009b_at_ryandesign.com> wrote:

> On Oct 28, 2009, at 04:01, Andrea Antonio Maleci wrote:
>
> > Executing command ‘make check’ after building SVN 1.6.5 I have this
> > failed tests:
> >
> > At least one test XFAILED, checking /private/home/csvn/
> > subversion-1.6.5/tests.log
> > XFAIL: lt-fs-test 18: merging commit
> > XFAIL: lt-locks-test 9: able to reserve a name (lock non-existent
> > path)
> > XFAIL: lt-locks-test 10: directory locks (kinda)
> > XFAIL: lt-tree-conflict-data-test 3: detect broken tree conflict data
> > XFAIL: basic_tests.py 39: remotely remove directories from two
> > repositories
> > XFAIL: update_tests.py 50: tree conflicts 2.3: skip on 2nd update
> > XFAIL: switch_tests.py 10: switch a file to a dir and back to the file
> > XFAIL: log_tests.py 21: test log -c on range of changes
> > XFAIL: diff_tests.py 28: diff a renamed directory
> > XFAIL: diff_tests.py 49: diff URL against working copy with local mods
> > XFAIL: diff_tests.py 50: diff -r1 of removed file to its local
> > addition
> > XFAIL: merge_tests.py 33: merge a replacement of a directory
> > XFAIL: merge_tests.py 34: replace both dir and one of its children
> > XFAIL: merge_tests.py 55: avoid repeated merges for cyclic merging
> > XFAIL: merge_tests.py 72: merge target with non inheritable mergeinfo
> > XFAIL: merge_tests.py 91: merge added subtree
> > XFAIL: merge_tests.py 115: tree conflicts 5.1: leaf edit, tree del
> > XFAIL: merge_tests.py 116: tree conflicts 5.2: leaf del, tree del
> > XFAIL: merge_tests.py 120: tree conflicts 5.1: leaf edit (no ci),
> > tree del
> > XFAIL: merge_tests.py 121: tree conflicts 5.2: leaf del (no ci),
> > tree del
> > XFAIL: merge_tests.py 125: merge prior to rename src existence still
> > dels src
> > XFAIL: revert_tests.py 4: revert a moved file
> > XFAIL: mergeinfo_tests.py 4: 'mergeinfo' with uninteresting source
> > selection
> > XFAIL: special_tests.py 10: diff a symlink to a directory
> > XFAIL: info_tests.py 2: info on added file
> > XFAIL: tree_conflict_tests.py 14: merge dir: del/rpl/mv onto not-same
> >
> > Are they right ?
> > What should I have missed ?
>
> Those are eXpected FAILures; they're supposed to fail if Subversion is
> functioning correctly.
>

My understanding was that XFAIL tests indicated actual test failures that
were known, and that should (eventually) be fixed. (Almost like a TODO list)

E.g. Scenario X produces result Y, but it should produce result Z. However,
making it produce Z is large chunk of work (and potentially a redesign of
something).

So add a test that runs X and expects Z, and mark it as XFAIL. Eventually,
when the work is done to actually produce Z, the test will pass (and no
longer be in the XFAIL list).

Is this understanding correct?

Cheers,
Daniel B.

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=1065&dsMessageId=2412370

To unsubscribe from this discussion, e-mail: [users-unsubscribe_at_subversion.tigris.org].
Received on 2009-10-29 04:21:45 CET

This is an archived mail posted to the Subversion Users mailing list.