Re: explaining syntax-check hook-script

Ryan Schmidt wrote on Mon, 7 Sep 2009 at 16:43 -0500:
> On Sep 7, 2009, at 16:39, Daniel Shahaf wrote:
> > Filenames are validated in libsvn_fs (fs-loader.c:path_valid()), log
> > messages in libsvn_repos (fs-wrap.c:validate_prop()). Only the former
> > set of checks applies during 'svnadmin load', but both sets apply during
> > commits and svnsync's.
>
> So... it would be possible to "svnadmin load" something with non-UTF-8 log
> messages, and then you wouldn't be able to "svnsync" that repository?

Yes. (Until 1.6.3, the same was true for non-LF log messages.)

> Are there plans to fix this?

Not that I know of. But the workaround is to edit the log messages
(after the 'svnadmin load') into valid UTF-8 (and LF newlines). We
(cmpilato) did that in the svn repository.

FWIW, separating the checks (of filenames v. log messages) is by
design (e.g., the semantics of svn:* props do not belong in the
filesystem layer).

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=1065&dsMessageId=2392174

To unsubscribe from this discussion, e-mail: [users-unsubscribe_at_subversion.tigris.org].
Received on 2009-09-07 23:56:40 CEST