[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: explaining syntax-check hook-script

From: Ryan Schmidt <subversion-2009b_at_ryandesign.com>
Date: Mon, 7 Sep 2009 16:43:47 -0500

On Sep 7, 2009, at 16:39, Daniel Shahaf wrote:

> Ryan Schmidt wrote on Mon, 7 Sep 2009 at 15:26 -0500:
>> On Sep 7, 2009, at 09:49, Marc Lustig wrote:
>>> We have the requirement to ensure that log-messages as well as file-
>>> names and the contents of character-based files are properly
>>> encoded, i .e. in UTF-8. Anybody knows a script to do this job?
>> For filenames and log message, Subversion should be checking this
>> already. It should not be possible for non-UTF-8 filenames or log
>> messages to end up in the repository. Though I think there may be
>> some
>> cases where it can happen, for example when loading a dumpfile via
>> svnadmin load? There seem to be more lax checks in place there than
>> with the "svn commit" or "svn import" mechanisms.
> Filenames are validated in libsvn_fs (fs-loader.c:path_valid()), log
> messages in libsvn_repos (fs-wrap.c:validate_prop()). Only the former
> set of checks applies during 'svnadmin load', but both sets apply
> during
> commits and svnsync's.

So... it would be possible to "svnadmin load" something with non-UTF-8
log messages, and then you wouldn't be able to "svnsync" that
repository? Are there plans to fix this?


To unsubscribe from this discussion, e-mail: [users-unsubscribe_at_subversion.tigris.org].
Received on 2009-09-07 23:44:41 CEST

This is an archived mail posted to the Subversion Users mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.