On Jun 10, 2009, at 01:24, Ramachandran, Vishwanath(IE10) wrote:
> Ryan Schmidt wrote:
>
>> On Jun 9, 2009, at 04:59, Ramachandran, Vishwanath(IE10) wrote:
>>
>>> The following properties has been enabled for the repository
>>> 1) Svn: log - Allow users to edit log messages
>>> 2) Svn: author- Allow users to edit author
>>>
>>> The above mentioned properties has enabled only for one
>>> administrator so
>>> that he can have the above two values
>>>
>>> But later, the admin want to remove the svn: author command to avoid
>>> changes to the author name and I have removed it. Since the svn:
>>> author
>>> is removed, his EID gets populated on notifications instead of
>>> name, and
>>> the admin wants the name back
>>>
>>> Would adding svn: author mean that now the author in the history
>>> can be
>>> modified again?
>>>
>>> I believe Author can be modified, but in the script it is written
>>> like
>>> user (i.e., admin) should only able to edit the logs, if that first
>>> condition exists we will not get author name
>>>
>>> While comparing user, even if we specify author it won't work
>>>
>>> If username has to be displayed I think we need to remove user
>>> condition
>>> also then this will applicable for all users
>>>
>>> What to do say? Can this be done? Please share your thoughts?
>>
>> It would help if you would show us the code of the relevant hook
>> script, and let us know what version of Subversion you are using and
>> on what operating system.
>
> Thanks for the response. Please find the attached text of the
> script. It
> pre-revprop change script
Ok, as I see it, the script does these things:
1. Sets some convenience variables.
2. If the property to be changed is svn:log, then allow the change if
the user is "e383084" or "crowdadmin", otherwise deny the change and
print an error message.
3. If the property to be changed is svn:author, allow the change.
4. For any other property, deny the change and print an error message
(though the error message it prints states that only editing svn:log
is permitted, which is not accurate).
If this is not what you want, how does it differ from what you want?
If the problem is not the behavior of the hook script, perhaps you
could rephrase what problem you're experiencing?
It does seem odd to me to allow anyone to change the author of any
commit. That means for example I could commit a change, then change
the author property to make it look like you committed it.
There is also a stray ":q" at the end of the file. I presume this has
to do with someone editing the file in vi.
> Subversion used is 1.4.6
> OS is Redhat Enterprise Linux 3
Although it might not relate specifically to this situation, you may
want to consider upgrading to a newer version of Subversion. The
current version is 1.6.2, and 1.4.x and older are no longer supported.
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=1065&dsMessageId=2360851
To unsubscribe from this discussion, e-mail: [users-unsubscribe_at_subversion.tigris.org].
Received on 2009-06-10 11:36:55 CEST