Re: mod_dav_svn issue? (was: git-svn: refuse to dcommit non-UTF-8 messages)

Am 03.06.2009, 16:18 Uhr, schrieb Stefan Sperling <stsp_at_elego.de>:

> On Wed, Jun 03, 2009 at 09:36:48AM +0200, Matthias Andree wrote:
>> ping - should I just file an issue in the tracker if nobody cares to
>> look here?
>>
>> Delegating input delegation to clients such as Perl/SVN::Ra, rather than
>> having the server - mod_dav_svn or whatever - check the commit log
>> character set seems like a serious issue (design flaw) to me (and
>> checking if something remotely looks like UTF-8 isn't exactly
>> difficult, look at
>> Markus Kuhn's pages for code if you need to pinch it...)
>
> Which version of Subversion are you using?
> This problem has already been fixed a while back.
> 1.6.x should not have this problem.

Hi Stefan,

thanks for the pointer and log message you'd included.

I'll check with our NOC for the version they'd been running on the server
and have their butts kicked if they'd been running an antediluvian version
(they've run into other - fixed - issues, such as ill-formed XML output on
non-UTF-8-log messages, so likely it was an older version, but I'll check).

> ------------------------------------------------------------------------
> r31614 | kfogel | 2008-06-06 19:28:03 +0100 (Fri, 06 Jun 2008) | 26 lines
>
> Fix issue #1796: prevent invalid log messages from entering the
> repository.

>> Git-SVN's fixing this is just a workaround for SVN design flaws and
>> implementation bugs.
>
> And let me guess -- git doesn't have any of those? ;)

Sure it does, but in this particular case, fixing git-svn was just a
courtesy, and fixing svn was the real fix.

-- 
Matthias Andree
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=1065&dsMessageId=2359133
To unsubscribe from this discussion, e-mail: [users-unsubscribe_at_subversion.tigris.org].