pre-revprop-change stdin wrong?

Using svn 1.5.1 FSFS and the http protocol, I created a pre-revprop-change
hook
script like this:

#!/bin/sh

echo "This stdin is from pre-revprop-change:" >&2
echo "-----" >&2
cat >&2
echo "" >&2
echo "-----" >&2
exit 1;

I then try to edit a revprop:

svn propedit "svn:log" --revprop -r 282 http://server/kmr_test

Edit the log message to say "new message" in my favorite editor and get:

subversion/libsvn_ra_neon/fetch.c:1175: (apr_err=175002)
svn: DAV request failed; it's possible that the repository's
pre-revprop-change hook either failed or is non-existent
subversion/libsvn_ra_neon/props.c:1151: (apr_err=175008)
svn: At least one property change failed; repository is unchanged
subversion/libsvn_ra_neon/util.c:206: (apr_err=175002)
svn: Error setting property 'log':
Revprop change blocked by pre-revprop-change hook (exit code 1) with
output:
This stdin is from pre-revprop-change:
-----
old log message
-----

I see a few things wrong here:

1) That is an ugly error message
2) The pre-revprop-change script gets the OLD log message passed to stdin
when it should
    get the NEW log message according to the tmpl file.

In the issue tracker I see a number of issues with the revprops scripts
but not this
particular one. (2635, 2990, 3085, 3112)

Am I missing something obvious? Yet another revprop hook script bug?

Kevin R.

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=1065&dsMessageId=1141741

To unsubscribe from this discussion, e-mail: [users-unsubscribe_at_subversion.tigris.org].
Received on 2009-02-12 01:16:33 CET