commit-email.pl adds spurious From "email@domain.tld" line

commit-email.pl does:

    if (defined $stdout)
      {
        $formatted_date = strftime('%a %b %e %X %Y', localtime())
        push(@head, "From $mail_from $formatted_date\n");
      }

I think this is not only unnecessary, but wrong. Not all MTAs remove that
spurious From-line, and if they don't (at least mini_sendmail doesn't), some
receiving MTAs get confused and lose the headers (at least MS Exchange
does.)

I commented that piece of code out, and the Outlook user began seeing the
headers they had missed.

This is subversion-tools-1.5.1.

-- v --

v_at_iki.fi

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: users-help_at_subversion.tigris.org
Received on 2008-10-22 20:03:19 CEST