[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: FW: Locks return "Bad Request"

From: D.J. Heap <djheap_at_gmail.com>
Date: 2007-06-30 19:58:22 CEST

On 6/23/07, Joel Low <joel@joelsplace.sg> wrote:
> Index: lock.c
> ===================================================================
> --- lock.c (revision 25430)
> +++ lock.c (working copy)
> @@ -449,6 +449,7 @@
> "Failed to generate a lock token.",
> resource->pool);
> dlock->locktoken = token;
> + dlock->next = NULL;
>
> /* allowing mod_dav to fill in dlock->timeout, owner, auth_user. */
> /* dlock->info and dlock->next are NULL by default. */
>
> That's all.
>
> However, I have a feeling that the issue is deeper than what I think it is,
> since I notice that the call to apr_pcalloc was used. Assuming that the
> apr_pcalloc is analogous to C's calloc, the memory returned should be
> Zero'ed completely and my code is unnecessary. This probably may just be a
> 'band-aid' fix for all I know.
>
> I'm not sure where this patch should really go though. If anyone wants to
> submit it to the proper bugtracker, please feel free to do so.

Were you compiling and testing this patch with 1.4.x or on a trunk
version? I can't recreate the problem on trunk with Apache 2.2.4 on
Vista. Would you mind trying a recent trunk build and seeing if it
still fails for you or has been fixed (I can provide test binaries if
you want to email me privately)?

Thanks!

DJ

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org
Received on Sat Jun 30 19:58:37 2007

This is an archived mail posted to the Subversion Users mailing list.