[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: FW: Locks return "Bad Request"

From: Joel Low <joel_at_joelsplace.sg>
Date: 2007-06-24 07:40:09 CEST

Index: lock.c
===================================================================
--- lock.c (revision 25430)
+++ lock.c (working copy)
@@ -449,6 +449,7 @@
                                "Failed to generate a lock token.",
                                resource->pool);
   dlock->locktoken = token;
+ dlock->next = NULL;
 
   /* allowing mod_dav to fill in dlock->timeout, owner, auth_user. */
   /* dlock->info and dlock->next are NULL by default. */

That's all.

However, I have a feeling that the issue is deeper than what I think it is,
since I notice that the call to apr_pcalloc was used. Assuming that the
apr_pcalloc is analogous to C's calloc, the memory returned should be
Zero'ed completely and my code is unnecessary. This probably may just be a
'band-aid' fix for all I know.

I'm not sure where this patch should really go though. If anyone wants to
submit it to the proper bugtracker, please feel free to do so.

Regards,
Joel

-----Original Message-----
From: D.J. Heap [mailto:djheap@gmail.com]
Sent: 24 June 2007 6:16 AM
To: Joel Low
Cc: users@subversion.tigris.org
Subject: Re: FW: Locks return "Bad Request"

On 6/15/07, Joel Low <joel@joelsplace.sg> wrote:
> Hello all,
>
> Okay, my change to set dlock->next = NULL in the sources seems to work.
I've
> built a mod_dav_svn.so binary and my Apache is running off it now. Seems
to
> work just fine.
>
> Joel

Can you submit a patch for this or at least give a bit more detail on
exactly where you made this change to fix the issue?

Thanks!

DJ

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org
Received on Sun Jun 24 07:40:47 2007

This is an archived mail posted to the Subversion Users mailing list.