[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

PATCH for bug in commit-email.pl

From: <johan556_at_gmail.com>
Date: 2007-06-20 12:14:00 CEST


I had some problems with "commit-email.pl" and the -m option. Digging
in the list archive, I saw that the same problem was discussed a while
ago (see the thread "Post commit issues using commit-email.pl" from
around 2007-05-10). But I didn't see any solution to the issue. So
here is an attempt to solve it. Below is a description of the problem
as I see it, and the patch I came up with.

Problem description
The script accumulates a list of "projects" in the variable
@project_settings_list. Each "project" is represented by a Perl HASH
reference. The script tries to support command lines both *with* and
*without* the -m option. When the -m option is used, an extra "ghost
project" is created. This is obviously wrong, but it seems that it
causes real problems only when direct SMTP delivery is used (as
opposed to using sendmail).

The patch
I made the patch against the file "commit-email.pl.in" in the trunk of
the Subversion archive. It is just a simple change to the way the
variable @project_settings_list is filled with values. I believe it
eliminates the extra "ghost project" that occurred when the -m option
was used.

/Johan Holmberg

To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org

Received on Wed Jun 20 12:14:26 2007

This is an archived mail posted to the Subversion Users mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.