Hi Louis,
To get these fixes into Subversion, I recommend:
1) Emailing this to dev@subversion.tigris.org.
2) Putting the [PATCH] string in the subject title.
3) Attaching the patch instead of including it inline, but have the
patch end in .txt so that it's reabable in email clients.
4) Add a log message. See this URL on how to write a log message:
http://subversion.tigris.org/hacking.html#log-messages
While some of this is extra work, it'll make it easier for it to get
into the code base, work that otherwise a committer would have to do.
BTW, which platform are you on that these fixes are needed?
Regards,
Blair
Louis Guillaume wrote:
> Sorry, that patch was mangled by line breaks... A good version is below.
>
> Louis Guillaume wrote:
>> The patch below fixes the portability problems with
>> subversion/tests/cmdline/davautocheck.sh
>
> --- subversion/tests/cmdline/davautocheck.sh.orig 2007-03-21 22:01:10.000000000 +0000
> +++ subversion/tests/cmdline/davautocheck.sh 2007-03-21 22:24:01.000000000 +0000
> @@ -62,7 +62,7 @@
> echo -n "$SCRIPT: $1 (y/n)? [$2] "
> read -n 1 -t 32
> echo
> - [ "${REPLY:-$2}" == 'y' ]
> + [ "${REPLY:-$2}" = 'y' ]
> }
>
> function get_loadmodule_config() {
> @@ -170,7 +170,7 @@
> || fail "Authz_User module not found."
> }
>
> -HTTPD_PORT=$(($RANDOM+1024))
> +HTTPD_PORT=$((($$ % 32768 ) +1024))
> HTTPD_ROOT="$ABS_BUILDDIR/subversion/tests/cmdline/httpd-$(date '+%Y%m%d-%H%M%S')"
> HTTPD_CFG="$HTTPD_ROOT/cfg"
> HTTPD_PID="$HTTPD_ROOT/pid"
> @@ -268,7 +268,7 @@
>
> say "HTTPD is good, starting the tests..."
>
> -if [ $# == 0 ]; then
> +if [ $# = 0 ]; then
> time make check "BASE_URL=$BASE_URL"
> r=$?
> else
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org
Received on Thu Mar 22 19:24:22 2007