[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn_load_dirs.pl bug when specifying a tag that already exists, and other bugs that led to it

From: Marc Girod <marc.girod_at_iona.com>
Date: 2006-11-17 20:11:18 CET

Blair Zajac <blair <at> orcaware.com> writes:

> If you put a patch together, I can review and shepherd it through and commit
> it.

Would you care to comment also the issue I submitted last week, and help to make
a better patch than the one I submitted?

It was about supporting changes in the type of some objects, e.g. from a file to
a directory.

The problems I saw were:
- the same thing is tested two times, before and after the renaming operation,
which couples code written in different places in the script
- as I understood it, one needs to perform two distinct commits: 1) to remove
the previous object, 2) to create the new
- of course one should collect together all the cases, so as not to do multiple
commits if there happens to be multiple type changes, as my simple minded patch
does
- there is already a patch concerning the support for soft links which seems to
have been waiting for a year or so without much attention of anybody; it should
be either committed, or clearly rejected, but not left unattended like that...
- a lot of attention has been spent as it seems to detect renames or moves, and
show them to the user; I didn't look in detail, but the result was verbose and
confusing to me, so that I ended up accepting a default behaviour without
clearly understanding what had happened.

Marc

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org
Received on Fri Nov 17 20:12:38 2006

This is an archived mail posted to the Subversion Users mailing list.