[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] svnversion - current working directory

From: Christopher Ness <chris_at_nesser.org>
Date: 2005-05-18 08:28:05 CEST

On Wed, 2005-05-18 at 11:41 -0500, C. Michael Pilato wrote:
> Christopher Ness <chris@nesser.org> writes:
>
> > I got sick of typing svnversion without a path and getting the usage
> > info.
>
> Heh. I think I ran svnversion for one of the first times ever last
> night, and had the same thought.
>
> Your patch (thank you much), lacks a log message. Please see HACKING
> for log message guidelines.

Log Message:

* /subversion/svnversion/main.c
  (main): Prints the version of the current working directory
  when called without arguments instead of the usage message.

> I was about to fuss because "." is not canonical for Subversion
> purposes, but then this section of code is dealing with user input,
> not yet canonicalized anyway, so I'm pretty sure "." here is fine.

Excellent, thanks for the review.
Reattached my little patch for good measure.

Cheers,
Chris

-- 
Wireless Group,
McMaster University
finger - 02:22:31 up 1 day, 31 min, 1 user, load average: 0.00, 0.02, 0.00


---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org

Received on Wed May 18 20:25:29 2005

This is an archived mail posted to the Subversion Users mailing list.