[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: Re: Commit - Approve cycle ?

From: James Moger <James.Moger_at_TRANSONIC.com>
Date: 2004-05-24 15:08:18 CEST

Sorry, I guess I wasn't clear enough:

Joe (developer) starts a commit transaction that requires Bob's (manager) approval.
Bob reviews Joe's changes and commits them as changeset #100.

svn log -r 100 url_to_repository
show Joe (developer) or Bob (manager) as the committer of the changeset?

- J

-----Original Message-----
From: Ben Collins-Sussman [mailto:sussman@collab.net]
Sent: Monday, May 24, 2004 8:59 AM
To: James Moger
Cc: users@subversion.tigris.org
Subject: RE: Re: Commit - Approve cycle ?

On Mon, 2004-05-24 at 07:54, James Moger wrote:
> That is very interesting. (We use Code Reviewer by SmartBear for
> reviewing pending changes - supports P4 & CVS. SVN is in beta). In
> the scenario you described would the manager's final commit preserve
> or overwrite the changeset's username (developer who initiated the
> commit)?

I'm not sure what you mean by "preserve" vs. "overwrite". It's a
transaction. Somebody creates it, then any number of people come along
and have the options of

   * examining it
   * making more changes to it
   * aborting it
   * committing it

A transaction is just a mutable tree; any number of people can share
it. It's just that nobody's written workflow apps to make use of them
like this. At the moment, 'svn commit' creates a transaction, edits it,
and commits it all in one step.

To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org
Received on Mon May 24 15:09:02 2004

This is an archived mail posted to the Subversion Users mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.