[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Pre-commit transaction modification question

From: <kfogel_at_collab.net>
Date: 2004-02-12 18:22:18 CET

Brett Wooldridge <brettw@riseup.com> writes:
> I'd be willing to signup to do this and send you guys the patches.

In fairness, you should be warned before devoting a lot of time to
this that -- IMHO only -- it's not likely to make it into Subversion
anytime soon.

This is just my prediction of the likely outcome of a developer
discussion, based on past such discussions, not a declaration that the
outcome *must* be so, of course. But I would certainly argue strongly
against such a feature, on the grounds that there are other ways to
achieve what you want to achieve, without us adding complexity to
Subversion.

If you still want to push for the feature, and write patches, go for
it. I'm just letting you know there will be resistance :-).

Best,
-Karl

> Mark wrote:
>
> >If my opinion as the administrator of several repositories in my
> >organization mattered, I'd be +1 on this. Seems like it's a good idea even
> >if the txn isn't being modified, just for safety's sake.
> >
> >Mark
> >
> >-----Original Message-----
> > From: Brett Wooldridge [mailto:brettw@riseup.com] Sent: Wednesday,
> > February 11, 2004 9:38 PM
> >To: Philip Martin
> >Cc: simon@ecnetwork.co.nz; users@subversion.tigris.org
> >Subject: Re: Pre-commit transaction modification question
> >
> > Would it be possible for the server to pass the new checksum back to
> > the client
> >in the commit-response? WebDav is request/response, right? So, when the
> > client recieves the commit response, it compares C' with C. 100% of
> > the time
> >with a non-modifying commit hook, C' will match C. In the case where they
> > do not match (i.e. with a hook that augmented F), the client could
> > refresh it's
> >copy from the repository. This seems like it would be a sound validation
> >regardless of permitting a pre-commit hook to augment the file. There is no
> > transaction violation by the pre-commit hook, as the transaction is
> > still open.
> > There is no corruption of the repository possible, merely a client
> > synchronization
> >issue to resolve.
> >
> >If you wanted a zero impact model in the nominal case, C' doesn't even need
> > to get sent in the reply if C and C' do not differ. It's presence
> > would indicate
> >that a difference was detected.
> >
> >bw
> >
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: users-help@subversion.tigris.org

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org
Received on Thu Feb 12 19:23:37 2004

This is an archived mail posted to the Subversion Users mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.